IQ.Pilot Release Commit @ ab07000

system/hardware/fan_controller.py

@@ -6,7 +6,11 @@ class FanController:
   def __init__(self) -> None:
     self.last_ignition = False
 
-  def update(self, cur_temp: float, ignition: bool) -> int:
+  def update(self, cur_temp: float, ignition: bool, max_cool: bool = False) -> int:
+    if max_cool:
+      self.last_ignition = ignition
+      return 100
+
     if cur_temp < 70.0:
       fan_pwr_out = 0
     elif cur_temp > 85.0:

system/hardware/hardwared.py

@@ -432,8 +432,6 @@ def hardware_thread(end_event, hw_queue) -> None:
     all_comp_temp = all_temp_filter.update(max(temp_sources))
     msg.deviceState.maxTempC = all_comp_temp
 
-    msg.deviceState.fanSpeedPercentDesired = fan_controller.update(all_comp_temp, onroad_conditions["ignition"])
-
     is_offroad_for_5_min = (started_ts is None) and ((not started_seen) or (off_ts is None) or (time.monotonic() - off_ts > 60 * 5))
     if is_offroad_for_5_min and offroad_comp_temp > OFFROAD_DANGER_TEMP:
       # if device is offroad and already hot without the extra onroad load,
@@ -447,6 +445,10 @@ def hardware_thread(end_event, hw_queue) -> None:
       elif current_band.max_temp is not None and all_comp_temp > current_band.max_temp:
         thermal_status = list(THERMAL_BANDS.keys())[band_idx + 1]
 
+    # the car is running but temperature is blocking the start, so cool as fast as we can
+    max_cool = (started_ts is None) and onroad_conditions["ignition"] and thermal_status >= ThermalStatus.red
+    msg.deviceState.fanSpeedPercentDesired = fan_controller.update(all_comp_temp, onroad_conditions["ignition"], max_cool)
+
     # **** starting logic ****
 
     startup_conditions["up_to_date"] = True

system/hardware/tests/test_fan_controller.py

@@ -41,6 +41,13 @@ class TestFanController:
     self.wind_up(controller, True)
     assert controller.update(100, True) == 100
 
+  @pytest.mark.parametrize("controller_class", ALL_CONTROLLERS)
+  def test_max_cool(self, mocker, controller_class):
+    controller = patched_controller(mocker, controller_class)
+    self.wind_down(controller)
+    assert controller.update(80, True, True) == 100
+    assert controller.update(80, False, True) == 100
+
   @pytest.mark.parametrize("controller_class", ALL_CONTROLLERS)
   def test_windup_speed(self, mocker, controller_class):
     controller = patched_controller(mocker, controller_class)

system/hardware/tici/hardware.py

@@ -85,8 +85,13 @@ def affine_irq(val, action):
 @lru_cache
 def get_device_type():
   # lru_cache and cache can cause memory leaks when used in classes
-  with open("/sys/firmware/devicetree/base/model") as f:
-    model = f.read().strip('\x00')
+  try:
+    with open("/sys/firmware/devicetree/base/model") as f:
+      model = f.read().strip('\x00')
+  except FileNotFoundError:
+    # off-device (e.g. the prebuilt build container fakes /TICI but has no
+    # devicetree); import must not crash. Not a real device type.
+    return "unknown"
   return model.split('comma ')[-1]
 
 class Tici(HardwareBase):