IQ.Lvbs/pycapnp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #259 from p4l1ly/memleak_fix

Browse Source 
memory leak fix: _SegmentArrayMessageReader: release each view
This commit is contained in:
Jacob Alexander
2021-05-13 08:33:06 -07:00
committed by GitHub
parent 73e83c91ee c0109662d2
commit 581332f9c9
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
capnp/lib/capnp.pyx
View File

@@ -4136,6 +4136,7 @@ cdef class _FlatArrayMessageReader(_MessageReader):
cdef class _SegmentArrayMessageReader(_MessageReader): cdef class _SegmentArrayMessageReader(_MessageReader):
cdef object _objects_to_pin cdef object _objects_to_pin
cdef uint num_segments
cdef schema_cpp.ConstWordArrayPtr* _seg_ptrs cdef schema_cpp.ConstWordArrayPtr* _seg_ptrs
cdef Py_buffer* views cdef Py_buffer* views
@@ -4146,6 +4147,7 @@ cdef class _SegmentArrayMessageReader(_MessageReader):
cdef schema_cpp.ConstWordArrayPtr seg_ptr cdef schema_cpp.ConstWordArrayPtr seg_ptr
self._seg_ptrs = <schema_cpp.ConstWordArrayPtr*>malloc(num_segments * sizeof(schema_cpp.ConstWordArrayPtr)) self._seg_ptrs = <schema_cpp.ConstWordArrayPtr*>malloc(num_segments * sizeof(schema_cpp.ConstWordArrayPtr))
self.views = <Py_buffer*>malloc(num_segments * sizeof(Py_buffer)) self.views = <Py_buffer*>malloc(num_segments * sizeof(Py_buffer))
self.num_segments = num_segments
self._objects_to_pin = [] self._objects_to_pin = []
for i in range(0, num_segments): for i in range(0, num_segments):
if PyObject_GetBuffer(segments[i], &self.views[i], PyBUF_SIMPLE) != 0: if PyObject_GetBuffer(segments[i], &self.views[i], PyBUF_SIMPLE) != 0:
@@ -4165,6 +4167,8 @@ cdef class _SegmentArrayMessageReader(_MessageReader):
def __dealloc__(self): def __dealloc__(self):
free(self._seg_ptrs) free(self._seg_ptrs)
for i in range(0, self.num_segments):
PyBuffer_Release(&self.views[i])
free(self.views) free(self.views)
del self.thisptr del self.thisptr