IQ.Lvbs/pycapnp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make reraise_kj_exception available to downstream

Browse Source 
I'm using Pycapnp in a project, where we compile `.capnp` files directly to
Cython instead of using the dynamic interface (for speed). For this, we need
access to the `reraise_kj_exception` C function defined by Pycapnp. This is not
possible, because Cython does not automatically make this function available to
downstream users.

My previous solution, in #301, was rather flawed. The  file `capabilityHelper.cpp`, where
`reraise_kj_exception` is defined, was bundled into the distribution, so that
this file could be included in downstream libraries. This turns out to be a
terrible idea, because it redefines a bunch of other things like
`ReadPromiseAdapter`. For reasons not entirely clear to me, this leads to
segmentation faults. This PR revers #301.

Instead, in this PR I've made `reraise_kj_exception` a Cython-level function,
that can be used by downstream libraries. The C-level variant has been renamed
to `c_reraise_kj_exception`.
This commit is contained in:
Lasse Blaauwbroek
2023-10-31 09:37:03 +01:00
committed by Jacob Alexander
parent 42665a61c9
commit aafec2281e
9 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
capnp/lib/capnp.pxd
View File

@@ -15,9 +15,9 @@ from capnp.includes.capnp_cpp cimport (
)
from capnp.includes.schema_cpp cimport Node as C_Node, EnumNode as C_EnumNode
from capnp.includes.types cimport *
from capnp.helpers.non_circular cimport reraise_kj_exception
from capnp.helpers cimport helpers
cdef void reraise_kj_exception()
cdef class _StructSchemaField:
cdef C_StructSchema.Field thisptr