IQ.Lvbs/pycapnp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix bare exception from str(obj)

Browse Source 
There is no test coverage for these exception clauses,
however the invocation of obj.__str__() for client
objects could raise any exception, hence the very broad
exception catch.
This commit is contained in:
John Vandenberg
2021-06-01 15:51:23 +08:00
parent a20e69dbe9
commit bd91c52d57
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
capnp/lib/capnp.pyx
View File

@@ -89,7 +89,7 @@ cdef api VoidPromise * call_server_method(PyObject * _server,
warning_msg = ( warning_msg = (
"Server function ({}) returned a value that was not a Promise: return = {}" "Server function ({}) returned a value that was not a Promise: return = {}"
.format(method_name, str(ret))) .format(method_name, str(ret)))
except: except Exception:
warning_msg = 'Server function (%s) returned a value that was not a Promise' % (method_name) warning_msg = 'Server function (%s) returned a value that was not a Promise' % (method_name)
_warnings.warn_explicit( _warnings.warn_explicit(
warning_msg, UserWarning, _inspect.getsourcefile(func), _inspect.getsourcelines(func)[1]) warning_msg, UserWarning, _inspect.getsourcefile(func), _inspect.getsourcelines(func)[1])
@@ -104,7 +104,7 @@ cdef api VoidPromise * call_server_method(PyObject * _server,
warning_msg = ( warning_msg = (
"Server function ({}) returned a value that was not a Promise: return = {}" "Server function ({}) returned a value that was not a Promise: return = {}"
.format(method_name, str(ret))) .format(method_name, str(ret)))
except: except Exception:
warning_msg = 'Server function (%s) returned a value that was not a Promise' % (method_name) warning_msg = 'Server function (%s) returned a value that was not a Promise' % (method_name)
_warnings.warn_explicit( _warnings.warn_explicit(
warning_msg, UserWarning, _inspect.getsourcefile(func), _inspect.getsourcelines(func)[1]) warning_msg, UserWarning, _inspect.getsourcefile(func), _inspect.getsourcelines(func)[1])
@@ -289,7 +289,7 @@ cdef api object get_exception_info(object exc_type, object exc_obj, object exc_t
return (exc_tb.tb_frame.f_code.co_filename.encode(), return (exc_tb.tb_frame.f_code.co_filename.encode(),
exc_tb.tb_lineno, exc_tb.tb_lineno,
(repr(exc_type) + ":" + str(exc_obj)).encode()) (repr(exc_type) + ":" + str(exc_obj)).encode())
except: except Exception:
return (b'', 0, b"Couldn't determine python exception") return (b'', 0, b"Couldn't determine python exception")