Fix ResourceWarning: unclosed file in setup.py

Also uniformize the usage of the 'with' context manager.

Signed-off-by: Mickaël Schoentgen <contact@tiger-222.fr>
This commit is contained in:
Mickaël Schoentgen
2019-01-14 22:59:33 +01:00
parent ccdb36a477
commit f6ecaa9b7f
2 changed files with 6 additions and 4 deletions

View File

@@ -3,12 +3,15 @@ from setuptools import setup, find_packages
install_requires = ["execnet>=1.1", "pytest>=3.6.0", "pytest-forked", "six"] install_requires = ["execnet>=1.1", "pytest>=3.6.0", "pytest-forked", "six"]
with open("README.rst") as f:
long_description = f.read()
setup( setup(
name="pytest-xdist", name="pytest-xdist",
use_scm_version={"write_to": "xdist/_version.py"}, use_scm_version={"write_to": "xdist/_version.py"},
description="pytest xdist plugin for distributed testing" description="pytest xdist plugin for distributed testing"
" and loop-on-failing modes", " and loop-on-failing modes",
long_description=open("README.rst").read(), long_description=long_description,
license="MIT", license="MIT",
author="holger krekel and contributors", author="holger krekel and contributors",
author_email="pytest-dev@python.org,holger@merlinux.eu", author_email="pytest-dev@python.org,holger@merlinux.eu",

View File

@@ -490,9 +490,8 @@ def test_session_hooks(testdir):
name = "worker" name = "worker"
else: else:
name = "master" name = "master"
f = open(name, "w") with open(name, "w") as f:
f.write("xy") f.write("xy")
f.close()
# let's fail on the worker # let's fail on the worker
if name == "worker": if name == "worker":
raise ValueError(42) raise ValueError(42)