Release 1.23.0

Optimize collection performance

CHANGELOG.rst

@@ -1,3 +1,12 @@
+pytest-xdist 1.23.0 (2018-08-23)
+================================
+
+Features
+--------
+
+- `#330 <https://github.com/pytest-dev/pytest-xdist/issues/330>`_: Improve collection performance by reducing the number of events sent to ``master`` node.
+
+
 pytest-xdist 1.22.5 (2018-07-27)
 ================================
 

testing/test_remote.py

@@ -321,8 +321,6 @@ class TestWorkerInteractor:
         assert not ev.kwargs
         ev = worker.popevent()
         assert ev.name == "collectreport"
-        ev = worker.popevent()
-        assert ev.name == "collectreport"
         rep = unserialize_report(ev.name, ev.kwargs["data"])
         assert rep.failed
         ev = worker.popevent("collectionfinish")

xdist/dsession.py

@@ -257,8 +257,12 @@ class DSession(object):
         self.sched.mark_test_complete(node, item_index, duration)
 
     def worker_collectreport(self, node, rep):
-        """Emitted when a node calls the pytest_collectreport hook."""
+        """Emitted when a node calls the pytest_collectreport hook.
-        if rep.failed:
+
+        Because we only need the report when there's a failure, as optimization
+        we only expect to receive failed reports from workers (#330).
+        """
+        assert rep.failed
         self._failed_worker_collectreport(node, rep)
 
     def worker_logwarning(self, message, code, nodeid, fslocation):

xdist/remote.py

@@ -109,6 +109,8 @@ class WorkerInteractor(object):
         self.sendevent("testreport", data=data)
 
     def pytest_collectreport(self, report):
+        # master only needs reports that failed, as optimization send only them instead (#330)
+        if report.failed:
             data = serialize_report(report)
             self.sendevent("collectreport", data=data)